There are multiple lines of code he

With Sheets(i.Value)
DestRow = .Cells(FirstRow + 29, FirstCol).End(xlUp).Offset(1).Row
.Cells(DestRow, FirstCol) = i.Offset(, -5)

While you're looping through your range, you're changing firstrow,
firstcol--depending on the worksheet name found in the cell on the TB worksheet.

So I put Investments in E2 (I used your original code).

Your code says to set these variables like:
Case "Investments":
FirstRow = 2
FirstCol = 5
SecondCol = 7
ThirdCol = 10

so
destrow = .cells(2+29,5).end(xlup).offset(1).row

says to start at range E31.
Then manually hit the end key and the upArrow (.end(xlup))
then drop down one row.

So it really depends on what you have in E31 and above.

Maybe it's as simple as looking at column G (=7) here, too????








Speedy wrote:

Dear Dave (number two)

I have found one more issue when experimenting with the code. The first row
logic does not work as expected. I don't totally follow the logic used in
the line DestRow = .Cells(FirstRow + 29,
FirstCol).End(xlUp).Offset(1).Row .Cells(DestRow, FirstCol) = i.Offset(, -5).

The aim was to have been able to start writing at whatever the DestRow was
set to in the logic above that. What happens it always starts at row 2 ?

Can you explain that to me please?

Stephane

"Dave Peterson" wrote:

First, I think keeping the discussion in the newsgroups is better. You get the
help of lots of people. (and my wrong answers can be corrected.)

if you get a "subscript out of range" error on a line like:

With Sheets(i.Value)

That means that the workbook that you're looking at doesn't contain a worksheet
that has the same name as what's in i (i.value).

So what's in i?
I'd put:
msgbox "****" & i.value & "****" & vblf & i.address
right before this line to see if I could see any extra spaces/spelling
differences.
(Everything between the asterisks is the .value)

I've found that when I have errors like this, it's usually a mistyped name in
the cell or I'm looking at the wrong workbook.

===
And using strings for those variables won't be helpful. Those are initialized
as empty strings ("").

And then .Cells(DestRow, ThirdCol) (with destrow and thirdcol both = "") will
cause trouble.




Speedy wrote:

Hello Dave, thanks for your interest.

I agree with your comment about the $A$1 thing. (as I'd mention to Myrna in
the previuous tread) but it only means that that part of the code will not
run and should make no difference. what it is meant to do is to trap the
error where there is no data in the sort code colum which is really E.

THe module ran OK with tha code as it was though. The problem came latter
when the Select Case was introduced to depending on the detail sheet name to
copy the data from the input sheet to a specifc location on the detail sheet
as these are not alway starting at the same co-ordinates for data input.

The model gets stuck at run time with the "With Sheets(i.Value)" line.

I think the option compare text is a good idea as there are in the real live
example many more detail sheets and the way it is written it requires a
perfect match which can be problematic.

Just a question if the variables are set to zero, would it not be better to
set up these as strings?

If you want I can send you the spreadsheet as I can appreciate it is better
to have the actual data and model together.

Thanks for your help.

Stéphane

"Dave Peterson" wrote:

Subscript 9 usually means you're refering to something that doesn't exist.

worksheets("sheet99") when you don't have a sheet99.

You may want to indicate which line of code is causing the problem.

I think that your code is tightly tied to your data--so it would be difficult to
guess anything specific--but you did get a question about this portion in your
other thread:

With Sheets("TB")
Set TBCodeRng = .Range("E2", .Range("E" & Rows.Count).End(xlUp))
End With
If TBCodeRng(1).Address = "$A$1" Then


If TBCodeRng is in column E, how can TBCodeRng(1).address ever point to column
A?

And just a general comment:

In your "select case" portion of code, you have this:

Select Case i.Value
Case "Investments":
FirstRow = 2
FirstCol = 5
SecondCol = 7
ThirdCol = 10
Case "Bank Balances":
FirstRow = 2
FirstCol = 3
SecondCol = 4
ThirdCol = 7
Case "Share Capital & Reserves":
FirstRow = 2
FirstCol = 6
SecondCol = 10
ThirdCol = 12
End Select

I'd add "option compare text" to the top of my module--so I wouldn't have to
worry about investments or INVESTMENTS or even InVeStMeNtS.

My real question:

What happens when a cell doesn't contain one of those strings. All your Long
variables are initialized to 0. You may want to add a check:

Select Case i.Value
Case "Investments":
FirstRow = 2
FirstCol = 5
SecondCol = 7
ThirdCol = 10
Case "Bank Balances":
FirstRow = 2
FirstCol = 3
SecondCol = 4
ThirdCol = 7
Case "Share Capital & Reserves":
FirstRow = 2
FirstCol = 6
SecondCol = 10
ThirdCol = 12
Case Else
'same kind of needs to be added to the calling routine
'as you used with SetRanges
CancelA = true
exit sub
End Select

Speedy wrote:

Please see the enclosed VBA code whose purpose is to populate details sheets
from an input sheet. There is a subscript error 9 when run. The detail
sheets are called "Investments" , "Bank" , etc. If you need the excel file
please advise and I will send it. Any advise on how to shorten the code or
improve the error trapping also welcomed. The code used to work OK until I
added the Select Case logic which is aimed at determining the write to
location in the detail sheets named Investments, Bank etc.

Any ideas?

Stéphane

Option Explicit
Dim UtilityCodeRng As Range
Dim TBCodeRng As Range
Dim CancelA As Boolean

Sub ShuffleData()
CancelA = False
SetRanges
If CancelA = True Then Exit Sub
ShuffleAllData
MsgBox "Copying of data complete.", , "Done"
End Sub

Sub SetRanges()
With Sheets("TB")
Set TBCodeRng = .Range("E2", .Range("E" & Rows.Count).End(xlUp))
End With
If TBCodeRng(1).Address = "$A$1" Then
MsgBox "There are no sort codes in the TB sheet." & Chr(13) & _
"This program will terminate.", , "No TB Sheet Data"
CancelA = True
Exit Sub
End If
End Sub

Sub ShuffleAllData()
Dim i As Range
Dim FirstRow As Long 'The first data row
Dim DestRow As Long 'The actual destination row
Dim FirstCol As Long 'The actual destination Column
Dim SecondCol As Long 'The actual destination Column number 2
Dim ThirdCol As Long 'The actual destination Column number 3

Sheets("TB").Activate
For Each i In TBCodeRng

'Note that i.Value is the destination sheet name.
Select Case i.Value
Case "Investments":
FirstRow = 2
FirstCol = 5
SecondCol = 7
ThirdCol = 10
Case "Bank Balances":
FirstRow = 2
FirstCol = 3
SecondCol = 4
ThirdCol = 7
Case "Share Capital & Reserves":
FirstRow = 2
FirstCol = 6
SecondCol = 10
ThirdCol = 12
End Select

'Let's say the destination range is defined as 30 rows max.
With Sheets(i.Value)
DestRow = .Cells(FirstRow + 29, FirstCol).End(xlUp).Offset(1).Row
.Cells(DestRow, FirstCol) = i.Offset(, -5)

'Test for Dr or Cr amount current year, Looks at colum C
If i.Offset(, -4) = "" Then
.Cells(DestRow, SecondCol) = i.Offset(, -3)
'Writes at Destination content of column D
Else
.Cells(DestRow, SecondCol) = i.Offset(, -4) * (-1)
'Writes content at destination of column C
End If
'Test for Dr or Cr amount for previous year (n-1), Looks at column F

If i.Offset(, -2) = "" Then
.Cells(DestRow, ThirdCol) = i.Offset(, -1)
'Writes content at destination of column F
Else
.Cells(DestRow, ThirdCol) = i.Offset(, -2) * (-1)
'Writes content at destination of column D

End If

End With
Next i
End Sub

--

Dave Peterson



--

Dave Peterson



--

Dave Peterson